RubyFlow The Ruby and Rails community linklog

×

The Ruby and Rails community linklog

Made a library? Written a blog post? Found a useful tutorial? Share it with the Ruby community here or just enjoy what everyone else has found!

[Gem] I made a gem to build an interactive graph based on gem dependencies from your Gemfile

by sivsushruth —

Please visit here . Constructive criticisms and suggestions welcome. Output is something like this

Comments

Pretty cool! I tried it out on one of my projects and I enjoyed visualizing the relationships.

I took a look at the code on Github, and three pieces of feedback on the code itself, in order of importance, IMO.

  1. Where are the tests?? No tests = no maintainability.
  2. Gemgrapher::Grapher#initialize is a 28-line imperative function. I’d consider embracing OO, extracting some private methods, and making the code more descriptive in the high-level. Code should read like a story.
  3. Tabs vs spaces. Ruby convention is to use two spaces, but the code contains both tabs and spaces.

Overall, great job!

originofstorms —

Post a comment

You can use basic HTML markup (e.g. <a>) or Markdown.

As you are not logged in, you will be
directed via GitHub to signup or sign in