[Gem] I made a gem to build an interactive graph based on gem dependencies from your Gemfile
by sivsushruth —
Please visit here .
Constructive criticisms and suggestions welcome.
Output is something like this
Comments
Pretty cool! I tried it out on one of my projects and I enjoyed visualizing the relationships.
I took a look at the code on Github, and three pieces of feedback on the code itself, in order of importance, IMO.
Where are the tests?? No tests = no maintainability.
Gemgrapher::Grapher#initialize is a 28-line imperative function. I’d consider embracing OO, extracting some private methods, and making the code more descriptive in the high-level. Code should read like a story.
Tabs vs spaces. Ruby convention is to use two spaces, but the code contains both tabs and spaces.
Comments
Pretty cool! I tried it out on one of my projects and I enjoyed visualizing the relationships.
I took a look at the code on Github, and three pieces of feedback on the code itself, in order of importance, IMO.
Overall, great job!
Post a comment